| commit | 2be34a9680f7999b692b0dad99918447516b228b | [log] [tgz] |
|---|---|---|
| author | Bastian Kersting <bkersting@google.com> | Tue Aug 29 10:45:12 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Aug 29 10:51:51 2023 |
| tree | 8bea84f72f459afacc4527bc491c359c221016a3 | |
| parent | 6b485e35460634a46c3885ccddf1fd1789907ff6 [diff] |
Revert "Reland "Update Chromium to use VMA 3.0"" This reverts commit 048603b3375064d2f34773bea1eb796882068848. Reason for revert: This fails the "blink_web_tests" suite on builder "chromium/ci/Linux Tests (dbg)(1)"; example failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/115429/overview More information in crbug.com/1476430 Original change's description: > Reland "Update Chromium to use VMA 3.0" > > This is a reland of commit 39d7f0daabd13c913865b2a583d6da21d77a5f70 > > An uninitialized value was causing errors in MSAN tests. > * Initialized the value of the VmaVulkanFunctions in CreateAllocator() > to {}. > > Original change's description: > > Update Chromium to use VMA 3.0 > > > > Following the change in ANGLE to add support for VMA 3.0, we must > > also update the VMA version used in Chromium. Currently ANGLE supports > > both VMA 2.3 and 3.0, via setting ANGLE_VMA_VERSION which is defined > > based on the build files. In Chromium, since this parameter is not set, > > ANGLE defaults to using VMA 2.3, which results in conflict if only the > > VMA hash is changed. > > * ANGLE CL: https://crrev.com/c/4777337 > > > > * Updated the VMA hash in the dependencies to the 3.0 version. > > * Updated the usage of some functions and variables in gpu/vulkan/ to > > be in line with the new VMA changes. > > * Added angle_vma_version to the build files. It is set to allow ANGLE > > to use VMA 3.0. > > * This parameter is added temporarily. When ANGLE removes support for > > VMA 2.3, it can be removed. > > > > Bug: b/295208838 > > Change-Id: I7a0592291d8d0d9902942d39f83e338647753521 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4794544 > > Reviewed-by: Peng Huang <penghuang@chromium.org> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > > Cr-Commit-Position: refs/heads/main@{#1186061} > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng > Bug: b/295208838 > Change-Id: I0e1b36cded6557a717bfb633eed783c1888d3607 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4803803 > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Commit-Queue: Amirali Abdolrashidi <abdolrashidi@google.com> > Cr-Commit-Position: refs/heads/main@{#1188566} Bug: b/295208838, crbug.com/1476430 Change-Id: Id19b23691590348eb5a97b71ff48fa7a211ac873 Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4821129 Commit-Queue: Bastian Kersting <bkersting@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Bastian Kersting <bkersting@google.com> Cr-Commit-Position: refs/heads/main@{#1189440} NOKEYCHECK=True GitOrigin-RevId: 1b5ae5b3047bd5479913c573aad2f5165febe5a8
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.