| commit | 33bc25fdbfa3354f48a2b430f4b7566b780049fc | [log] [tgz] |
|---|---|---|
| author | Yuly Novikov <ynovikov@chromium.org> | Wed Nov 02 17:00:51 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Nov 02 17:07:03 2022 |
| tree | c3856cd5f04a6c2ee04b031c49ee1fada7f4d21d | |
| parent | eeed7ed6c0fab5a7186c8d0aedf57c5421409add [diff] |
Allow third-party repositories to disable C++20 for MSVC For example, some ANGLE targets fail to compile with MSVC and C++20, so allow to use C++17 instead. Bug: 1284275, 1380553, 1380455 Change-Id: Ib60a25fe60b5fd98506264cf1dc970d731367776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3997254 Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1066541} NOKEYCHECK=True GitOrigin-RevId: 2c98c5af6539d7ffc10fbe83d3e76216b7e01186
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.