| commit | 3cacaf6a0249b40aefea50feccca033693cb8bc6 | [log] [tgz] |
|---|---|---|
| author | Arthur Sonzogni <arthursonzogni@chromium.org> | Wed Oct 12 09:45:55 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Oct 12 09:52:28 2022 |
| tree | 0def144700a4a20e3a4ffb9542280d44bbe845c0 | |
| parent | 199de5ff0d22c2c220ce342192d61f2e465ead04 [diff] |
DanglingPtr: disable binary flag before branch cut. The DanglingPointer binary flag has been enabled for a few canary versions. We need to turn it of before the M108 branch cut. More details: https://docs.google.com/document/d/1khePUp8OyOBOzzfGZREwPwGnISBMkyMWiy54HWFSrZQ/edit Bug: 1373383 Change-Id: I96d48b72a06db64dc7f5408e2506c93a422e7eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937937 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1057951} NOKEYCHECK=True GitOrigin-RevId: cd2946182c7beadeb370a9986ef3506cc6ea9008
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.