commit | 3e7fb6b3150279228f524ebb5f436ac87bfa3d82 | [log] [tgz] |
---|---|---|
author | David Neto <dneto@google.com> | Thu Feb 15 21:45:50 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 15 21:55:23 2024 |
tree | 0e26aba87e530cd66bb48b66ca1ee74e6e75c6b0 | |
parent | a91d39e76c0aa412b4490ca74697158ff7d726fd [diff] |
Remove angle_spirv_cross_dir from angle.gni The use of that definition was removed from ANGLE in crrev.com/c/4003675 Bug: dawn:2399 angleproject:6081 Change-Id: I15c076965acfc405a2aff224344fb8883c5921a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5300356 Commit-Queue: David Neto <dneto@google.com> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: David Neto <dneto@google.com> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1261317} NOKEYCHECK=True GitOrigin-RevId: d46ba75ed7a83db36431d4669a22bc5335d24a1c
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.