commit | 4592dfd665de4c8c4552f19d64c906fdbfeb6961 | [log] [tgz] |
---|---|---|
author | Arthur Sonzogni <arthursonzogni@chromium.org> | Fri Mar 15 10:47:18 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Mar 15 10:52:55 2024 |
tree | 6720858e0e4024a6e8f7871badf35e940abb8799 | |
parent | c9330b5ec3addd9ea863e5bf721414cec1ae0c8d [diff] |
Enable DanglingPointerDetector on Windows (dcheck && !official) The DanglingPointerDetector is currently enabled by default on Linux, and there are specific bots for other platforms. This patches adds Windows by default. Follow-ups: - Cleanup the win-rel config. - Iterate for every other platforms Benefits: - No more CQ vs CI differences (See chromium:327473315) - Increased coverage. Include-Ci-Only-Tests: true Bug: chromium:328104161, chromium:327473315 Change-Id: I15fad09ed44150ab007852bb398bd22f16256bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5345629 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Owners-Override: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1273325} NOKEYCHECK=True GitOrigin-RevId: e2c6afce60b755ff2c23b236baf045375715177a
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.