| commit | 512f09f4d837478b101604ea312320b3604d28d2 | [log] [tgz] |
|---|---|---|
| author | Kalvin Lee <kdlee@chromium.org> | Mon Nov 07 13:55:18 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Nov 07 14:00:17 2022 |
| tree | 44c079c24b4e579cfceb1aa7e0bfb9dad95f6780 | |
| parent | bbc5b062d54baf0bde5f30e337922a6bc61d4282 [diff] |
[PA] Move `use_partition_alloc` This CL trivially moves the declaration of the build arg `use_partition_alloc` from `//base/allocator/allocator.gni` to PA's `partition_alloc.gni`. Some other `BUILD.gn`s are changed to import `partition_alloc.gni`, in order to continue using `use_partition_alloc`. This CL introduces no behavioral change, but is intended to allow PA to express the `use_partition_alloc` concept in embedder GN recipes. Much as Chromium already does, the idea is to allow embedders to gate inclusion of the PA sources on `use_partition_alloc`. Bug: 1371729 Change-Id: I342a0860602a3c74c8254e37eda6d5c5700447b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3985428 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Auto-Submit: Kalvin Lee <kdlee@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/main@{#1068074} NOKEYCHECK=True GitOrigin-RevId: 41a852742c157b191a98a2739548b2308117a1c6
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.