commit | 532cc06987f2e88de41981a6793d7a2601abeeec | [log] [tgz] |
---|---|---|
author | Yuly Novikov <ynovikov@chromium.org> | Fri Mar 24 18:55:47 2023 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Mar 24 19:00:54 2023 |
tree | e50383f8dc0b17f166c375f670ca1be03697c328 | |
parent | 92b9e457f02302956c1cbf5bf04256514a7fe2a5 [diff] |
Update msvc_use_cxx17 comment ANGLE no longer needs it, the only user now is pdfium Bug: 1380553, pdfium:1932 Change-Id: I5b719ce2683d2e943d78a03eef6ad1b2ff5ef0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369966 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1121851} NOKEYCHECK=True GitOrigin-RevId: a620726418ddf04a4eac4b8822fd801ce7edae28
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.