| commit | 549f0134fddcda283012b2fd44b40b117bf0afba | [log] [tgz] |
|---|---|---|
| author | Björn Terelius <terelius@chromium.org> | Wed Aug 09 16:55:45 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Aug 09 17:04:53 2023 |
| tree | c0ba1ec1ef2e510c16c707a15b290cd6e04899ef | |
| parent | 4f70b49579452217659f1eb3c12a8f5930375e15 [diff] |
Move use_cxx17 build flag from build/config/compiler to build_overrides WebRTC hasn't moved to C++20 yet, but we now need to use it when compiling Android due to the JNI generator depending on Chromium's //base which started using C++20 features. By moving the flag to build_overrides, we can conditionally set it based on target_os. Bug:b/294976628, chromium:1402249 Change-Id: I6fc5a669cf9287cb2beb43873016c7560b399185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4758705 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Björn Terelius <terelius@chromium.org> Cr-Commit-Position: refs/heads/main@{#1181536} NOKEYCHECK=True GitOrigin-RevId: d6dfe7b51826898fb5c7993161b12dba8360ea9f
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.