| commit | 5a1398144604b0ba1dafcc1b91e5ea72f74f4238 | [log] [tgz] |
|---|---|---|
| author | Arthur Sonzogni <arthursonzogni@chromium.org> | Mon Oct 16 19:08:55 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Oct 16 19:16:26 2023 |
| tree | 835e94deb2b2641b109b51b555df10cc06f9ca18 | |
| parent | 0febb1cf4bba9222abeb303f4a69a3a2cc376168 [diff] |
[PA] Move README, OWNERS, DEPS, BUILD.gn to top-level dir. This is a follow-up to: https://chromium-review.googlesource.com/c/chromium/src/+/4812338 The previous patch moved the whole PA directory into "src/partition_alloc" without putting much thinking about individual files. This follow-up moves the README, OWNERS, DEPS, BUILD.gn file into the top-level directory. Bug: chromium:1467773 Change-Id: Ie9f457fe957bbf27779892eece606eb220d50cb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4934632 Owners-Override: danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Takashi Sakamoto <tasak@google.com> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1210356} NOKEYCHECK=True GitOrigin-RevId: c8ca46524226127e51531c08bab01d049d4a3083
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.