commit | 75543f518adbae8b7b6f5d8c17c7df320aca0157 | [log] [tgz] |
---|---|---|
author | Jose Dapena Paz <jdapena@igalia.com> | Thu Feb 29 08:29:17 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 29 08:38:56 2024 |
tree | fa2a0ae06e9a575f518aba37d06583dd5f0585bc | |
parent | 057ac6281f7e32eb44303df74740842833adebae [diff] |
Enable lightweight libstdc++ assertions Add the GN argument enable_safe_libstdcxx, that enables libstdc++ lightweight assertions, that protect against different bad conditions as invalid array indexes. Bug: 1497935 Change-Id: Icb8e85f47295d258bc5ec7bdd32fa58f06b4dcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4994044 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by: Dirk Pranke <dpranke@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1266874} NOKEYCHECK=True GitOrigin-RevId: ad472c5485fa292346a900c529eb207424486094
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.