| commit | 7877134d7f6db686ab39761537ff7692aa3de380 | [log] [tgz] |
|---|---|---|
| author | Keishi Hattori <keishi@chromium.org> | Tue Jan 24 04:14:33 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Jan 24 04:20:42 2023 |
| tree | 910e2e8bed10e23ad5d46bdaf2d4179cac04c2fc | |
| parent | e884f29115fd2f5388ee66b1aecbdf081a513d7d [diff] |
Revert "Enable BRP SLOW_CHECKS temporarily for a few Canary releases" This reverts commit 834e067592cb5ca266edaea4bb2fb5320155b0b5. Reason for revert: Temporary change. Original change's description: > Enable BRP SLOW_CHECKS temporarily for a few Canary releases > > Enable BRP SLOW_CHECKS temporarily for a few Canary releases to check for bugs. > > Binary-Size: Increase is temporary. > Change-Id: If8c7cf797061cca4cf4fb314de1ec5f98082e307 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4186938 > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1095571} Change-Id: I586f29198f71ae2b29023a608cd0f1c142f0e719 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4190936 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1096013} NOKEYCHECK=True GitOrigin-RevId: 1fca35b1f037923309fcf5496c4f229c0bc01c63
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.