| commit | 7e33f28a1ba8071e7b9ae32d4dbf79f25b898feb | [log] [tgz] |
|---|---|---|
| author | Arthur Sonzogni <arthursonzogni@chromium.org> | Mon Apr 15 19:15:39 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Apr 15 19:31:19 2024 |
| tree | a71f06cae4eb23c51559e05d3587e9ff8f0840ac | |
| parent | dc37d380f38ced6a09c47aea7e2dd873074b9520 [diff] |
Enable DanglingPointerDetector on ChromeOS (dcheck && !official) The DanglingPointerDetector is currently enabled by default on Linux, and there are specific bots for other platforms. This patches adds ChromeOS by default. Follow-ups: - Cleanup the win-rel config. - Iterate for every other platforms Benefits: - No more CQ vs CI differences (See chromium:327473315) - Increased coverage. Include-Ci-Only-Tests: true Cq-Include-Trybots: luci.chromium.try:chromeos-amd64-generic-rel-gtest,chromeos-amd64-generic-rel-gtest-and-tast,lacros-amd64-generic-rel-gtest-and-tast,lacros-amd64-generic-rel-non-skylab,linux-cfm-rel,linux-lacros-rel Bug: chromium:328104161, chromium:327473315 Change-Id: I27d25a089b2aa8404c9d4d8314910b9c6ec1fe5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5385328 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1287539} NOKEYCHECK=True GitOrigin-RevId: 43ec36472c4792789d7c2d500a271f8d5d5df2f8
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.