commit | 87493f353a9f3e9764324905812ad127d579ba9d | [log] [tgz] |
---|---|---|
author | Lei Zhang <thestig@chromium.org> | Tue Mar 05 01:40:13 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Tue Mar 05 01:49:02 2024 |
tree | b0fd73adc36e06ace684d10a2a52eed6fc679334 | |
parent | 75543f518adbae8b7b6f5d8c17c7df320aca0157 [diff] |
Remove unneeded build/config/cast.gni imports Remove imports from files that do not otherwise contain the word "cast". Add a missing import in fuchsia_web/shell/BUILD.gn so the removals do not break the build. For instance, third_party/libpng/BUILD.gn has not needed the import since https://crrev.com/399464. Change-Id: I723391900e4877caecc98f3db45f4673280292b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5341769 Commit-Queue: Lei Zhang <thestig@chromium.org> Owners-Override: Lei Zhang <thestig@chromium.org> Reviewed-by: Junji Watanabe <jwata@google.com> Cr-Commit-Position: refs/heads/main@{#1268198} NOKEYCHECK=True GitOrigin-RevId: 567b543cea8368008181efdd9f3434963755418a
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.