commit | 8dc39f36b43518f08b878365f8a7b340cde1bbd3 | [log] [tgz] |
---|---|---|
author | Daniel Cheng <dcheng@chromium.org> | Fri Feb 17 23:02:37 2023 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Feb 17 23:09:21 2023 |
tree | 25215a68179bd5db4917ff6843d363df18984c3f | |
parent | 71d9c1c9abf9562067bdb24864975391c7fe47b7 [diff] |
Allow projects embedding Chrome to disable libc++ hardening. This moves enable_safe_libcxx to build_overrides so that external projects embedding Chrome can disable libc++ hardening if deemed appropriate for those project's requirements. In order to ease the transition for projects that utilize Chrome's //build, c++.gni still defines enable_safe_libcxx as a fallback for now. Once various external projects have picked up this change, the fallback will be removed. Bug: 1385662 Change-Id: I81dcadcbb3a6d528f98ae21b018845cae486804e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4036347 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#1107045} NOKEYCHECK=True GitOrigin-RevId: 6688da75512e6ee0555129d2041e0b498ee3ff33
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.