| commit | 92b9e457f02302956c1cbf5bf04256514a7fe2a5 | [log] [tgz] |
|---|---|---|
| author | Nicolas Ouellet-Payeur <nicolaso@chromium.org> | Thu Mar 16 14:10:42 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Mar 16 14:16:40 2023 |
| tree | 2406aabcb83b9c4642cdc8fd83191581f0b9be7c | |
| parent | 43f6d3b5136600fae5a5074b1890d86f7a1e8186 [diff] |
Revert "[PA] Enable PA-E on Linux component build." This reverts commit 28f066239038fa7b18a2d1e38973036459ad911e. Reason for revert: Failing checks in browser_tests on Linux [1]. eg: > [ RUN ] AccessCodeCastBrowserProxyTest.All > ../../base/allocator/partition_allocator/memory_reclaimer.cc(29) Check failed: it_and_whether_inserted.second [1] https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/112051 Original change's description: > [PA] Enable PA-E on Linux component build. > > Change-Id: I2c7b9a36695b0a582871a7252e79d8aeef396c60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4236004 > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/main@{#1117962} Change-Id: Id0563eb74bdf209acc5b47e4bb140f2cec5a086c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4346152 Owners-Override: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1118075} NOKEYCHECK=True GitOrigin-RevId: 502a16f9df24ee38bda3c4c512a1c3c917def985
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.