| commit | 9c6898f34730d9bd141a14149d498d77f387242a | [log] [tgz] |
|---|---|---|
| author | Sunny Sachanandani <sunnyps@chromium.org> | Tue Apr 25 02:15:20 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Apr 25 02:21:26 2023 |
| tree | afdf62ee09f07ec2b6b2df139c8295b647dc523a | |
| parent | c4990982dc34264acc2a1b28c61ac94a2ddebbc5 [diff] |
gpu: Enable Tint SPIRV reader for Graphite Dawn Skia Graphite's Dawn backend uses SPIRV shaders so Tint support needs to be enabled. This code path is disabled by default, both via build and feature flags so this change is a no-op for default Chromium builds. Bug: 1423574 Change-Id: I537f8c77b2e43e377b30cf2257ea1ed0aeadd6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4471307 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/main@{#1134988} NOKEYCHECK=True GitOrigin-RevId: 07047c8e959682db06a7b6013416c7f23d318c21
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.