| commit | 9de4031586f84ecc31cc512834b18f322cb7a34b | [log] [tgz] |
|---|---|---|
| author | Antonio Sartori <antoniosartori@chromium.org> | Fri Jun 16 10:00:39 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Jun 16 10:06:13 2023 |
| tree | a3a7a39b52d98130ac9850d00a14c2c6c46d53ab | |
| parent | 2a7fc924aa6f02fd572e3f12c38257ecc3ca4e88 [diff] |
Revert "[PA] Add partition_alloc_optimized_debug to partition_alloc.gni." This reverts commit 4ef79b5f8468216bf85da0588c78850bf8688fd8. Reason for revert: Seems to have increased duration of browser tests by about 20%, see chromium:1455341 Original change's description: > [PA] Add partition_alloc_optimized_debug to partition_alloc.gni. > > Add partition_alloc_optimized_debug to PartitionAlloc to enable > PartitionAlloc-Everywhere on Linux debug build. This is the same way > as v8 does, i.e. v8_optimized_debug. > > Bug: 1151236, 1449923, 1429450 > > Change-Id: I6abfbdb3d0ef11104ec7ccf9edcaef4e21ddb1f4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4599609 > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/main@{#1158006} Bug: 1151236, 1449923, 1429450, 1455341 Change-Id: Ida8e829f92f538412c3455a6cc4b6026d6360790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4620228 Owners-Override: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1158730} NOKEYCHECK=True GitOrigin-RevId: ebd57a5ea737542120f1b752e5857c8d775ab6ed
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.