commit | bbc5b062d54baf0bde5f30e337922a6bc61d4282 | [log] [tgz] |
---|---|---|
author | Yuly Novikov <ynovikov@chromium.org> | Wed Nov 02 20:05:34 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Nov 02 20:10:40 2022 |
tree | 86c0a65b2567c7352d1f26a3a07a503909455da0 | |
parent | 33bc25fdbfa3354f48a2b430f4b7566b780049fc [diff] |
Add a TODO to remove msvc_use_cxx17 build flag Bug: 1380553 Change-Id: If667caa2718135f5733fc6cf09d5db28d2be841c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000520 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1066641} NOKEYCHECK=True GitOrigin-RevId: 57d6f95c1be6b25de0780ff6f17ac8e289128ef4
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.