| commit | bf4964bbf508482c161b6ae3c6271ca015a607ce | [log] [tgz] |
|---|---|---|
| author | Brandon Jones <bajones@chromium.org> | Fri Mar 10 18:39:12 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Mar 10 18:55:38 2023 |
| tree | 25215a68179bd5db4917ff6843d363df18984c3f | |
| parent | 322435f5c58e93d694cc0488b7bb08c9ebce2cee [diff] |
Reland "Resubmit #2: Enable WebGPU for Android builds" This reverts commit a7963f9255822231d1205c888cb80e7e81e2295a. Reason for revert: Issue that prompted revert was potentially fixed by https://dawn-review.googlesource.com/c/dawn/+/123440 Original change's description: > Revert "Resubmit #2: Enable WebGPU for Android builds" > > This reverts commit e9e3257cc233916311b8f6713f618cebc9fc95cc. > > Reason for revert: Chrome on Android is currently triggering an LLD bug, blocking the Dawn roll into Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1422246 > > Original change's description: > > Resubmit #2: Enable WebGPU for Android builds > > > > Non-component Android builds were being blocked by ANGLE producing > > multiple .so files, but a previous Dawn change has temporarily > > disabled ANGLE in Dawn on Android, clearing the way for this change. > > > > Also activates the "Enable Unsafe WebGPU" and "WebGPU Developer > > Features" flags in about:flags. > > > > Previously reverted due to some failing gl_tests. Fixed in: > > https://chromium-review.googlesource.com/c/chromium/src/+/4209568 > > > > Another test failure was found after landing the previous iteration of > > this CL. The fix is contained within this CL directly. > > > > Additionally there were some Vulkan crashes that occured while it > > was enabled. Fixed in: > > https://dawn-review.googlesource.com/c/dawn/+/117594 > > > > This commit is expected to increase the binary size of Chrome on Android > > by about 1.5Mb. This is mostly due to the new inclusion of the Dawn > > library, which provides Chrome's cross-platform implementation of the > > WebGPU API. Because WebGPU is a large new feature a proportional size > > increase is to be expected. By comparison a roughly equivalent library, > > ANGLE, also adds approximately the same amount to the binary size. > > > > See https://groups.google.com/a/google.com/g/webgpu-developers/c/g2NB5rR2R2A/m/73b9HQC2AgAJ > > for further discussion about the size impact. > > > > Bug: dawn:286 > > Change-Id: Ie9377a6c64324141ddfad1ace36135881ea34f27 > > Binary-Size: Added a new library to enable large feature. > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4212140 > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Commit-Queue: Brandon Jones <bajones@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1100089} > > Bug: dawn:286 > Change-Id: Ib7b4d2a86d5ea09c2cca441040a1f7d40c2a9457 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4318042 > Reviewed-by: Brandon Jones <bajones@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Stephen White <senorblanco@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1114363} Bug: dawn:286 Change-Id: I910b0495bf72c42302edf36356c2a0346a80910c Binary-Size: Added a new library to enable large feature. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4327969 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/main@{#1115818} NOKEYCHECK=True GitOrigin-RevId: 11b7db067f1ade9d3c744ecdbb22ec1251f93672
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.