| commit | c04e34915a526bcb3ffc41770e9a087bf6e509b3 | [log] [tgz] |
|---|---|---|
| author | Hui Yingst <nigi@chromium.org> | Tue Nov 08 18:59:47 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Nov 08 19:06:56 2022 |
| tree | 274b0cd83523b36013416028962e1dd3181e014d | |
| parent | 512f09f4d837478b101604ea312320b3604d28d2 [diff] |
Use flag "pdf-use-skia-renderer" to switch PDF viewer's renderer Link flag "pdf-use-skia-renderer" with PDFiumEngine so that it can actually switch the renderer type for the PDF viewer upon initialization. This CL also changes PDFiumTestBase and tests derived from it into parameterized tests so that they can be tested with Skia renderer enabled: - For the tests which involve image rendering results comparison, add the Skia expectations for them. - Test PDFiumPageImageDataTest.ImageData is currently skipped because it crashes when Skia renderer is in use. Bug: 1379872 Change-Id: I90d69e8a34e607dc9a049baf9c46d81569976f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000168 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Nigi <nigi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1068688} NOKEYCHECK=True GitOrigin-RevId: ba504e872bf30ac4d253f0ee082b87ec63bfba33
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.