commit | c68862f570eb2a3230816e4f9eadaf2f4ea65469 | [log] [tgz] |
---|---|---|
author | Mikhail Khokhlov <khokhlov@google.com> | Thu Jan 12 19:25:12 2023 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Jan 12 19:29:56 2023 |
tree | ca8c71d93253909db98203092d06bf1036b073ce | |
parent | 8f00c11f3bbd891c7a60eb2961f92f07381f04d4 [diff] |
Reland "[Tracing] Use Perfetto client library for tracing on Linux" This is a reland of commit d9e2da27d146aedf4cd8fb1dfd75b593fd346e53 The build and test failures that were triggered by the original change have been addressed: https://chromium-review.googlesource.com/c/v8/v8/+/4152474 https://chromium-review.googlesource.com/c/chromium/src/+/4154637 Original change's description: > [Tracing] Use Perfetto client library for tracing on Linux > > This CL switches the Chrome tracing backend to Perfetto client > library. It means that Chrome on Linux will use a different set of > TRACE_EVENT* macros that call Perfetto client API under the hood. > > Our end goal is to make Perfetto the default backend on all platforms, > unblocking multiple improvements in tracing stability and usefulness. > The Linux change is a first step towards that goal. > > Bug: 1006541 > Change-Id: I85f27a2e4b91f219e9fb4f90a391f4b5df90baa3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4147340 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1090340} Bug: 1006541 Change-Id: I0ba9a161bf92a2268156fce55ab9ba8956c5b1ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4163217 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/main@{#1091983} NOKEYCHECK=True GitOrigin-RevId: aa7e8dcd5f5665afecaa9463ecbbb8a4ac6d6199
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.