| commit | c9330b5ec3addd9ea863e5bf721414cec1ae0c8d | [log] [tgz] |
|---|---|---|
| author | Kalvin Lee <kdlee@chromium.org> | Fri Mar 08 08:41:29 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Mar 08 09:00:00 2024 |
| tree | b6a5cdc3fe305023b23c932c622fda2f24c9ec32 | |
| parent | 16a6b3a64bdefa4fcddd7b7a46e4328735e86718 [diff] |
PA: Prefer just "PartitionAlloc" Common parlance has favored "PartitionAlloc" for quite a while now. This best-effort CL was constructed from a naive `git grep` to replace other spellings (e.g. "partition alloc," "Partition Alloc," "partition allocator," etc.) with the most common one. This change was created with `git cl split` and is scoped to /build_overrides. This CL was uploaded by git cl split. R=hans@chromium.org Change-Id: I1c82c7e3586c4eff844083111f729ec9741cbdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5355407 Auto-Submit: Kalvin Lee <kdlee@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/main@{#1270074} NOKEYCHECK=True GitOrigin-RevId: c39e2898c8e9a36f2bcb6ec2d94a1ac0b8bf8865
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.