commit | d3ce4d1858f63886fe44c2fbb773b3502f3396cf | [log] [tgz] |
---|---|---|
author | Dylan Cutler <dylancutler@google.com> | Fri May 14 18:01:21 2021 |
committer | Copybara-Service <copybara-worker@google.com> | Fri May 14 18:09:52 2021 |
tree | 517759e3b5ce8617055509cf959048baa0c25b83 | |
parent | 115de76f00f6387c7648dcb0ef47aabccec3425a [diff] |
Replace 'blacklist' with 'ignorelist' in ./tools/msan/. Bug: 1097272, 1097268 Change-Id: Id5c8227a5bfb1ffaec82d3168b609085b10c8297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2867730 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#883035} NOKEYCHECK=True GitOrigin-RevId: 3b6263f2eece1264b052dfdcbc03b851d5abfb48
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.