| commit | dc64d7212e67d5589287726a84e88e3fa27cafe5 | [log] [tgz] |
|---|---|---|
| author | Austin Sullivan <asully@chromium.org> | Thu Feb 01 20:15:01 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Feb 01 20:23:28 2024 |
| tree | c62259147c0d662f5ef72b4bd83443ebee124e8c | |
| parent | 348e89d59d65d161dc69306f3089a480df12f4f5 [diff] |
Revert "[mac] Enable perfetto client library" This reverts commit c9f979ce20bd97fddc22a76083544e02f4362e65. Reason for revert: Suspected to cause failures on Mac arm64 bots For example: https://ci.chromium.org/ui/p/chromium/builders/ci/mac13-arm64-rel-tests/15718/overview Original change's description: > [mac] Enable perfetto client library > > This uses new TRACE_EVENT* macro implemented in perfetto. > This was previously tried and reverted at https://chromium.googlesource.com/chromium/src/+/06e237b24dc8a588a569fbfb80e87a0faebaf467 > The underlying issue crbug.com/1479357 should be fixed. > > Bug: 1006541 > Change-Id: Iddebd6e40da79a302eacb3e5643a01e17813ef48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245869 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1255112} Bug: 1006541, 1524099 Change-Id: Ia8eb510a7a625a03299e91772a17b89500d6d85b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5260165 Auto-Submit: Austin Sullivan <asully@chromium.org> Owners-Override: Austin Sullivan <asully@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1255242} NOKEYCHECK=True GitOrigin-RevId: 9ff7f823a7b52fb406d83847a5e72f4a07fa2f42
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.