commit | eb2fd180ef241fec19e615a14ca091b283fbda9f | [log] [tgz] |
---|---|---|
author | Kalvin Lee <kdlee@chromium.org> | Wed Dec 07 03:41:53 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Dec 07 03:45:29 2022 |
tree | 910e2e8bed10e23ad5d46bdaf2d4179cac04c2fc | |
parent | fcd6f81480d5a365f77418eb131fee6913e607ff [diff] |
[PA] Unpublicize new BRP build arg The new publicized requirement for embedders to define `backup_ref_ptr_poison_oob_ptr_default` in `//build_overrides/partition_alloc.gni` breaks external embedders. Since this is not likely to see use outside of Chromium, we elect to fix this by removing the `_default` dependency for now. Change-Id: I93f062c156b9b609ea9af245a9364ec067c67c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4082131 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#1080154} NOKEYCHECK=True GitOrigin-RevId: 8aa82267adf9f65914cead7c53c805cc1312da59
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.