| commit | eeed7ed6c0fab5a7186c8d0aedf57c5421409add | [log] [tgz] |
|---|---|---|
| author | Bartek Nowierski <bartekn@chromium.org> | Fri Oct 21 20:00:08 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Oct 21 20:07:07 2022 |
| tree | 1ea96c4bbefadd96a403c9049c90ca092ddc80b3 | |
| parent | 209cc670c2337cd71deb9f8b178d16fb77cab900 [diff] |
[PA] Introduce use_partition_alloc_as_malloc (2 of N) This is one in the series of CLs that aims at replacing use_allocator and use_partition_alloc_as_malloc with use_partition_alloc_as_malloc. use_allocator == "partition" <=> use_partition_alloc_as_malloc == true use_allocator == "none" <=> use_partition_alloc_as_malloc == false This CL switches from enable_partition_alloc_as_malloc_support and use_allocator to use_partition_alloc_as_malloc everywhere. Once landed, use_allocator will be useless and can be removed from GN args. enable_partition_alloc_as_malloc_support too, but that doesn't seem to be set anywhere anyway. Bug: 1151236 Change-Id: Ie1c99b92e0f533513a20d56d69cecb1c903dd320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3965990 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Takashi Sakamoto <tasak@google.com> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1062311} NOKEYCHECK=True GitOrigin-RevId: 07f51c672390638de7eb7310b627d2d22e483a65
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.