| commit | efb505f25e591da0c59792c38b0022cfc1f53a3d | [log] [tgz] |
|---|---|---|
| author | Etienne Pierre-doray <etiennep@chromium.org> | Mon Feb 05 19:45:24 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Mon Feb 05 19:55:41 2024 |
| tree | 00c0881b9a1dff6641061c2a69ca82163e2d54d8 | |
| parent | dc64d7212e67d5589287726a84e88e3fa27cafe5 [diff] |
Reland "[mac] Enable perfetto client library" This is a reland of commit c9f979ce20bd97fddc22a76083544e02f4362e65 Reason for revert: crbug.com/1524099 Fix: - ScopedMLTraceTest handle 'n' (Instant async event) as begin/end - SystemTracingEndToEndBrowserTest.PerformanceMark: increase connect timeout. Original change's description: > [mac] Enable perfetto client library > > This uses new TRACE_EVENT* macro implemented in perfetto. > This was previously tried and reverted at https://chromium.googlesource.com/chromium/src/+/06e237b24dc8a588a569fbfb80e87a0faebaf467 > The underlying issue crbug.com/1479357 should be fixed. > > Bug: 1006541 > Change-Id: Iddebd6e40da79a302eacb3e5643a01e17813ef48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5245869 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1255112} Bug: 1006541, 1524099 Change-Id: I174c72e7091a20cc758870461a4d83e37fc19281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258709 Reviewed-by: Dirk Pranke <dpranke@google.com> Owners-Override: Dirk Pranke <dpranke@google.com> Reviewed-by: Eric Seckler <eseckler@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256340} NOKEYCHECK=True GitOrigin-RevId: d9c94f21f11dd95d015b68a588d7c72d5f1babb2
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.