| commit | f0380692e0a39ef3a630af05450d5bb3ab105de9 | [log] [tgz] |
|---|---|---|
| author | Arthur Sonzogni <arthursonzogni@chromium.org> | Thu Nov 17 16:47:37 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Nov 17 16:55:39 2022 |
| tree | 274b0cd83523b36013416028962e1dd3181e014d | |
| parent | 8a79a7c0f01c73f7de84e5dfd78c2c9971701ac3 [diff] |
Revert "Enable DPD performance experiment temporarily." This reverts commit 7998c6f0e505a434f8b3783f7e1636d978a6eba6. Reason for revert: This was meant to be temporary. This has been used during 5 canary build. No stability issues detected. See: https://docs.google.com/document/d/1khePUp8OyOBOzzfGZREwPwGnISBMkyMWiy54HWFSrZQ/edit?hl=en&forcehl=1#bookmark=id.tnyrs9rs2p8a Original change's description: > Enable DPD performance experiment temporarily. > > Goal is to double check the patch passes on all the non-CQ bots. This > way, we can make the dev/beta binary experiment more confidently. > > Bug: 1341550 > Change-Id: I4105099ed8a0ebaccbd748706e8419b3b6182baf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4020202 > Commit-Queue: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1071433} Bug: 1341550 Change-Id: I8584714dc148107778a1999fe2861761f4f8e59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4031178 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1072851} NOKEYCHECK=True GitOrigin-RevId: d6860006c1905ce71ff6ff877a0d1685e0319f64
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.