commit | f083fd6b5b930f97f7cbc12dbfdc96356e9294f0 | [log] [tgz] |
---|---|---|
author | Lei Zhang <thestig@chromium.org> | Thu Oct 26 19:15:09 2023 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Oct 26 19:22:59 2023 |
tree | 41714aa6f96d2da5e0c899ab18ae36f9d4752b60 | |
parent | 5a1398144604b0ba1dafcc1b91e5ea72f74f4238 [diff] |
Remove msvc_use_cxx17 GN arg This GN arg has no users left. Bug: pdfium:1932 Change-Id: I86c6be35be94b7654360ce7115bda7bf01a1e777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4976182 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1215670} NOKEYCHECK=True GitOrigin-RevId: 79e716546968f27c2f386898446f5349845e760d
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.