| commit | f897c3fe0a75140568ee73e47c9d8647b38e5944 | [log] [tgz] |
|---|---|---|
| author | Dave Tapuska <dtapuska@chromium.org> | Tue Sep 05 16:16:17 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Tue Sep 05 16:24:56 2023 |
| tree | 443516aa2c721f404c57db2ac8e617cc7066971c | |
| parent | 9b359731434557359615d851ede625ae7465ae84 [diff] |
Revert "[mac] Enable perfetto client library" This reverts commit 06e237b24dc8a588a569fbfb80e87a0faebaf467. Reason for revert: Lots of perf regression bugs need to analyze them. Original change's description: > [mac] Enable perfetto client library > > In the future we will have an optimization for ModuleCache > with the client library path. Mac will be able to take advantage > of this if it is using the client SDK. > > Bug: 1006541 > Change-Id: I06bfc9c9260a8f1f7ea25b9db56d5d9875bfd619 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4824087 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1190436} Bug: 1006541 Change-Id: I1b10e8856376a159433fcdc41cc8986111e74b25 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4831331 Auto-Submit: Dave Tapuska <dtapuska@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1192505} NOKEYCHECK=True GitOrigin-RevId: dd4e131af171c6dea14c47f8f73bcb5f2ca49b73
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.