commit | fcd6f81480d5a365f77418eb131fee6913e607ff | [log] [tgz] |
---|---|---|
author | Maksim Sisov <msisov@igalia.com> | Mon Dec 05 08:14:55 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Mon Dec 05 08:19:33 2022 |
tree | 986a7cb9f642f6b12294c2b0ecfde695316e87d0 | |
parent | 4d9bc667dba4809acc0e845f92f18630b623a24c [diff] |
libwayland: remove use_system_libwayland Removes outstanding bits of use_system_libwayland usage in src/ There are a couple of users in third_party, which are different projects. Thus, build_overrides/wayland.gni still defines that gn arg for them. Bug: 1385736 Change-Id: I44fd50e9fbb79a7409cff681c9c16a81ad8c81a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4065945 Reviewed-by: Joe Downing <joedow@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Alexander Dunaev <adunaev@igalia.com> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/main@{#1079112} NOKEYCHECK=True GitOrigin-RevId: 1c3c8db518f78cb2d08a3990e5280e324c4a6e99
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.