Google Git
Sign in
chromium / chromium / src / sandbox / a51ab1a2a3634deb3859991e11876787e1652c25
commita51ab1a2a3634deb3859991e11876787e1652c25[log] [tgz]
authorNicolas Arciniega <niarci@microsoft.com>Thu Mar 03 19:23:28 2022
committerCopybara-Service <copybara-worker@google.com>Thu Mar 03 19:44:10 2022
tree7c77d8a6c256fe8c4acf55367a45ec1c5ba2812a
parent4000e85e5c3956a408913eaf511a105f4e7553d0 [diff]
Update DCHECK for AddAppContainerProfileToPolicy result

I'm unable to reproduce the flaky test issue and the logs do not
provide much helpful information. Updating the DCHECK to a
DCHECK_EQ will cause the `result` to be printed when the test flakes.
Hopefully, this will help me find a root cause.

Bug: 1032820, 1280214
Change-Id: I7b4eec39eba4bba8f0870fbec2a8b8d9f82f841c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499464
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#977258}
NOKEYCHECK=True
GitOrigin-RevId: aa1aa3708a3103eb56d3054c7dc6e880c2bb003f
1 file changed
tree: 7c77d8a6c256fe8c4acf55367a45ec1c5ba2812a
  1. linux/
  2. mac/
  3. policy/
  4. win/
  5. BUILD.gn
  6. COMMON_METADATA
  7. constants.h
  8. DEPS
  9. DIR_METADATA
  10. features.cc
  11. features.gni
  12. features.h
  13. ipc.dict
  14. OWNERS
  15. README.md
  16. sandbox_export.h
README.md

Sandbox Library

This directory contains platform-specific sandboxing libraries. Sandboxing is a technique that can improve the security of an application by separating untrustworthy code (or code that handles untrustworthy data) and restricting its privileges and capabilities.

Each platform relies on the operating system's process primitive to isolate code into distinct security principals, and platform-specific technologies are used to implement the privilege reduction. At a high-level:

  • mac/ uses the Seatbelt sandbox. See the detailed design for more.
  • linux/ uses namespaces and Seccomp-BPF. See the detailed design for more.
  • win/ uses a combination of restricted tokens, distinct job objects, alternate desktops, and integrity levels. See the detailed design for more.

Built on top of the low-level sandboxing library is the //sandbox/policy component, which provides concrete policies and helper utilities for sandboxing specific Chromium processes and services. The core sandbox library cannot depend on the policy component.