newblue: add format attributes; fix related warnings

A bug kept us from diagnosing non-constant format strings. Cleaning
those up led to a few custom log functions, which can each be tagged
with a special attribute to get clang to do extended format string
checking.

This CL adds said attribute, and cleans up places where we had incorrect
format strings

BUG=chromium:958601
TEST=emerge-{oak,falco} chromeos-base/newblue

Change-Id: I6278a3026b2d99cd2942a650356bc80d40c23de0
Reviewed-on: https://chromium-review.googlesource.com/1592111
Commit-Ready: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
7 files changed