Google Git
Sign in
chromium / chromiumos / platform / standalone-hdctools / 8e0eeaf6444f58eb9bc5478e1b18d973dd9f53f4
commit8e0eeaf6444f58eb9bc5478e1b18d973dd9f53f4[log] [tgz]
authorDavid Schneider <dnschneid@chromium.org>Tue Mar 31 23:45:51 2020
committerDavid Schneider <dnschneid@chromium.org>Fri Apr 03 22:40:56 2020
tree9530ec64440204135cfdfd181a1fc7c59d4c9636
parenta1ba00b4fdd61d0ff4c21db257d32f2524cee0c3 [diff]
Remove unnecessary usages of sudo from flash_ec

Since we're running outside of the chroot, most usages at best are
unnecessary (since the user is likely already in the correct groups) or
at worst will fail due to the location of utilities.

Change-Id: I95b03eafcfd7febeb7f115656879c4c7986cf4a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/standalone-hdctools/+/2131393
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: David Schneider <dnschneid@chromium.org>
Commit-Queue: David Schneider <dnschneid@chromium.org>
Tested-by: David Schneider <dnschneid@chromium.org>
1 file changed
tree: 9530ec64440204135cfdfd181a1fc7c59d4c9636
  1. dut-control ⇨ servod
  2. flash_ec ⇨ flashrom
  3. servodutil ⇨ servod
  4. flashrom
  5. README.md
  6. servod
README.md

Standalone scripts for hardware debug and control

This is a repository of scripts that enable common hardware debug tasks outside of a Chromium chroot.

When all you need is quick access to servod, flashrom, or others, the wrapper scripts here will get you up and running without the overhead of creating, syncing, or entering a chroot.

Usage

This repo is designed such that you can clone or download the entire repo and run scripts within, or grab and run individual scripts.

Running individual scripts

You can download and run individual scripts without checking out the entire repo:

script=servod
repo='https://chromium.googlesource.com/chromiumos/platform/standalone-hdctools/'
curl -f "${repo}/+/master/${script}?format=TEXT" | base64 -d > "${script}"
"./${script}"

Guidelines

  • Follow the Chromium shell style guidelines.
  • Unless making a symlink, do not assume any other script in the repo is available.
  • With few exceptions, these scripts should download, prepare, and run other Chromium OS tools -- not provide any new functionality.

Making changes

Since this repo isn‘t in the manifest, it won’t show up in your chroot. Instead, to make changes:

git clone https://chromium.googlesource.com/chromiumos/platform/standalone-hdctools
cd standalone-hdctools
curl -Lo .git/hooks/commit-msg https://gerrit-review.googlesource.com/tools/hooks/commit-msg
chmod +x .git/hooks/commit-msg
git checkout -b changes
# (make some changes)
git commit -a
git push origin HEAD:refs/for/master

The above steps will upload a patch to chromium-review.googlesource.com where you can get your patch reviewed, and submit.