commit 47abccfb3601f8ae9ce6b377faf23f64d777c947
author Allen Vicencio <allenvic@chromium.org> Thu Feb 01 23:18:31 2018
committer chrome-bot <chrome-bot@chromium.org> Thu Feb 08 05:27:18 2018
tree 4c72e80e72b53ef81eae3db5604fd94c1285787b
parent ab305e65f6d6d180c8a63607a6de65c9b726525b

smbprovider: Refactor kCreateFilePermissions to kCreateEntryPermissions

Refactors the name of the constant for create file permissions in
preparation for CreateDirectory.

BUG=chromium:757625
TEST=unit tests run

Change-Id: Ib68a867cc4b99fd5739e047abe9caa790b8fd378
Reviewed-on: https://chromium-review.googlesource.com/898551
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

smbprovider/constants.h

diff --git a/smbprovider/constants.h b/smbprovider/constants.h
index 9ee10a5..d8d31f8 100644
--- a/smbprovider/constants.h
+++ b/smbprovider/constants.h
@@ -17,8 +17,8 @@
 // Default flags for created files.
 constexpr int kCreateFileFlags = O_CREAT | O_WRONLY | O_TRUNC | O_EXCL;
 
-// Default permissions for created files.
-constexpr mode_t kCreateFilePermissions = 0755;
+// Default permissions for created entries.
+constexpr mode_t kCreateEntryPermissions = 0755;
 
 // SMB Url scheme
 constexpr char kSmbUrlScheme[] = "smb://";

smbprovider/samba_interface_impl.cc

diff --git a/smbprovider/samba_interface_impl.cc b/smbprovider/samba_interface_impl.cc
index f0c5959..e5709e5 100644
--- a/smbprovider/samba_interface_impl.cc
+++ b/smbprovider/samba_interface_impl.cc
@@ -107,7 +107,7 @@
 int32_t SambaInterfaceImpl::CreateFile(const std::string& file_path,
                                        int32_t* file_id) {
   *file_id =
-      smbc_open(file_path.c_str(), kCreateFileFlags, kCreateFilePermissions);
+      smbc_open(file_path.c_str(), kCreateFileFlags, kCreateEntryPermissions);
   if (*file_id < 0) {
     *file_id = -1;
     return errno;