commit 8028ab77d4c511b5be1c5f19044f4b2a0ba7863d
author Allen Vicencio <allenvic@chromium.org> Fri Mar 09 20:09:52 2018
committer chrome-bot <chrome-bot@chromium.org> Wed Mar 14 02:00:00 2018
tree 741d9cf323067f467f766ab05b44767bdc70b3d4
parent e5640a079f5a91532050a5aa9beff76d48e7d843

smbprovider: Refactor AddEntryIfValid to identify shares as directories

AddEntryIfValid will identify entries with type SMBC_FILE_SHARE as a
directory. This is done so that is_directory will be true for shares in
DirectoryEntryProto.

BUG=chromium:757625
TEST=unit tests run
Change-Id: Ia69d38675704a636e428e189ab7e51b8ee090f1b
Reviewed-on: https://chromium-review.googlesource.com/957547
Commit-Ready: Allen Vicencio <allenvic@chromium.org>
Tested-by: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>

smbprovider/iterator/directory_iterator.cc

diff --git a/smbprovider/iterator/directory_iterator.cc b/smbprovider/iterator/directory_iterator.cc
index 9344cb8..454a109 100644
--- a/smbprovider/iterator/directory_iterator.cc
+++ b/smbprovider/iterator/directory_iterator.cc
@@ -154,7 +154,8 @@
   if (IsSelfOrParentDir(name) || !ShouldIncludeEntryType(dirent.smbc_type)) {
     return;
   }
-  bool is_directory = dirent.smbc_type == SMBC_DIR;
+  bool is_directory =
+      dirent.smbc_type == SMBC_DIR || dirent.smbc_type == SMBC_FILE_SHARE;
   directory_entries->emplace_back(is_directory, name,
                                   AppendPath(parent_dir_path, name));
 }