| commit | 015f8e3a58f86567c1748d9d3698bd2939bd6157 | [log] [tgz] |
|---|---|---|
| author | John L Chen <zuan@chromium.org> | Tue Jun 28 09:23:25 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Jul 07 16:01:03 2022 |
| tree | 6c170ee3a3d0ffefb7cc45360185f652013df135 | |
| parent | a7e19b5b5d9a0901c9d12f3de0e76d7daa6787f8 [diff] |
system_api: Add CryptohomeErrorInfo to Unmount, Remove and ListKeys BUG=b:229708597 TEST=CQ and CLs later in the chain Change-Id: I79fcd564f26d673ccb7ffe5063db6291118cd1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/3731854 Tested-by: John L Chen <zuan@chromium.org> Reviewed-by: Leo Lai <cylai@google.com> Commit-Queue: John L Chen <zuan@chromium.org> NOKEYCHECK=True GitOrigin-RevId: a0729389d2658427388f86e1f933529b7e82876f
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.