commit d790111f8e619bd13475926482aacf996a776446
author Qijiang Fan <fqj@chromium.org> Tue Jan 14 05:04:49 2020
committer Commit Bot <commit-bot@chromium.org> Wed Jan 15 03:47:56 2020
tree 64f2aac110f660f0cd3d9cd8c1c20f77f24132b4
parent 88aa40800795f515cc44aa5ce6979f6ee866e4b6

aver-updater: use -std=gnu++14 and std::make_unique

Newer libchrome header file needs to be compiled with C++14.

Also since C++14, we have std::make_unique, so remove make_unique in
flavor of std::make_unique.

BUG=chromium:909719
TEST=emerge-endeavour aver-updater

Change-Id: I6b8553f37410a83ad8af807114ff45eb07039f2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/aver-updater/+/1999588
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Joe Tessler <jrt@chromium.org>
Reviewed-by: Qijiang Fan <fqj@google.com>
Commit-Queue: Qijiang Fan <fqj@google.com>
Tested-by: Qijiang Fan <fqj@google.com>

common.mk

diff --git a/common.mk b/common.mk
index 26c0940..c44f9b6 100644
--- a/common.mk
+++ b/common.mk
@@ -321,7 +321,7 @@
 COMMON_CFLAGS-clang := -fvisibility=hidden -ggdb
 COMMON_CFLAGS := -Wall -Wunused -Wno-unused-parameter -Werror -Wformat=2 \
   -fno-strict-aliasing $(SSP_CFLAGS) -O1
-CXXFLAGS += $(COMMON_CFLAGS) $(COMMON_CFLAGS-$(CXXDRIVER)) -std=gnu++11
+CXXFLAGS += $(COMMON_CFLAGS) $(COMMON_CFLAGS-$(CXXDRIVER)) -std=gnu++14
 CFLAGS += $(COMMON_CFLAGS) $(COMMON_CFLAGS-$(CDRIVER)) -std=gnu11
 CPPFLAGS += -D_FORTIFY_SOURCE=2
 

src/target_device.cc

diff --git a/src/target_device.cc b/src/target_device.cc
index 38d5916..8a30bfd 100644
--- a/src/target_device.cc
+++ b/src/target_device.cc
@@ -32,10 +32,6 @@
 constexpr unsigned int kAVerCAM540ProductID = 0x0970;
 constexpr unsigned int kAVerNewCAM540ProductID = 0x09A0;
 
-template <typename T, typename... Ts>
-std::unique_ptr<T> make_unique(Ts&& ... params) {
-  return std::unique_ptr<T>(new T(std::forward<Ts>(params)...));
-}
 }  // namespace
 
 TargetDevice::TargetDevice()
@@ -72,12 +68,11 @@
 
     switch (hid_type) {
       case kModelOneDevice:
-        devices_.push_back(make_unique<ModelOneDevice>(device_name,
-                                                       it->second,
-                                                       fw_mid_name));
+        devices_.push_back(std::make_unique<ModelOneDevice>(
+            device_name, it->second, fw_mid_name));
         break;
       case kModelTwoDevice:
-        devices_.push_back(make_unique<ModelTwoDevice>(it->second));
+        devices_.push_back(std::make_unique<ModelTwoDevice>(it->second));
         break;
       default:
         break;