Fix read_spi_flash_page()
The data[0] check coincidentally worked for the serial number check
but, unlike with other USB API calls, data[0] is not the length of
bytes returned but the first byte of data.
Change-Id: I6b7c834e94cfce96cd3e7b134b2ccd9097846c6f
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/11308
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
diff --git a/em100.c b/em100.c
index 16c4077..7c0a7f8 100644
--- a/em100.c
+++ b/em100.c
@@ -350,10 +350,7 @@
}
int len = get_response(em100->dev, data, 256);
- // FIXME are pages really effectively 255 bytes, or
- // is this part of the format of the config page and
- // thus the check for 255 needs to be moved to get_serialno()
- if ((len == 256) && (data[0] == 255)) {
+ if (len == 256) {
memcpy(blk, data, 256);
return 1;
}
