| From c373367093fe84e9145f7478754d4077f817ac8a Mon Sep 17 00:00:00 2001 |
| From: Dmytro Maluka <dmaluka@chromium.org> |
| Date: Tue, 5 Dec 2023 16:45:28 +0000 |
| Subject: [PATCH] CHROMIUM: drm/print: Don't add events to drm trace instance |
| |
| We only use the drm trace instance for printing drm logs to |
| /sys/kernel/tracing/instances/drm/trace, not for event tracing. Yet we |
| needlessly populate /sys/kernel/tracing/instances/drm/events with all |
| the same events as the global tracer (so the vast majority of those |
| events have nothing to do with drm). |
| |
| As a result we have 2x more files in tracefs, which in particular |
| results in ~14MB more slab memory consumed for tracefs inodes in |
| tracefs_create_file(). |
| |
| So disable adding any events to the drm instance. |
| |
| BUG=b:309475612 |
| UPSTREAM-TASK=b:311737594 |
| TEST=1. No event directories in /sys/kernel/tracing/instances/drm/events |
| 2. In /proc/meminfo SReclaimable is 12-14MB lower than w/o this CL |
| |
| Change-Id: I7d80aabfeae4c1cdfa3ac0a5986063108c71573c |
| Signed-off-by: Dmytro Maluka <dmaluka@chromium.org> |
| Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/5132216 |
| Tested-by: Dmytro Maluka <dmaluka@google.com> |
| Reviewed-by: Drew Davenport <ddavenport@chromium.org> |
| --- |
| drivers/gpu/drm/drm_print.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c |
| index 177840c90104ed037aaaccc834ce1a0070001acf..cc196ee86086e00c1b456e4cc97f528147f7a398 100644 |
| --- a/drivers/gpu/drm/drm_print.c |
| +++ b/drivers/gpu/drm/drm_print.c |
| @@ -486,7 +486,7 @@ void drm_trace_init(void) |
| { |
| int ret; |
| |
| - trace_arr = trace_array_get_by_name("drm"); |
| + trace_arr = trace_array_get_by_name("drm", ""); |
| if (!trace_arr) |
| return; |
| |
| -- |
| 2.44.0.rc0.258.g7320e95886-goog |
| |
