| From 7efcd998e189db8cdb0b75c1cd8fece7e54388e7 Mon Sep 17 00:00:00 2001 |
| From: Rajat Jain <rajatja@google.com> |
| Date: Fri, 25 Mar 2022 11:46:08 -0700 |
| Subject: [PATCH] BACKPORT: FROMLIST: PCI: ACPI: Support Microsoft's |
| "DmaProperty" |
| |
| The "DmaProperty" is supported and documented by Microsoft here: |
| https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports |
| They use this property for DMA protection: |
| https://docs.microsoft.com/en-us/windows/security/information-protection/kernel-dma-protection-for-thunderbolt |
| |
| Support the "DmaProperty" with the same semantics. This is useful for |
| internal PCI devices that do not hang off a PCIe rootport, but offer |
| an attack surface for DMA attacks (e.g. internal network devices). |
| |
| Signed-off-by: Rajat Jain <rajatja@google.com> |
| Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> |
| Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| (am from https://patchwork.kernel.org/patch/12792004/) |
| (also found at https://lore.kernel.org/r/20220325184609.4059963-1-rajatja@google.com) |
| |
| Conflicts: |
| drivers/pci/pci-acpi.c |
| |
| BUG=b:215424986 |
| TEST=Build & Boot, and check wifi is flagged as untrusted. |
| |
| Change-Id: I17d988617e15c01437c91ca13547c3658d27a541 |
| Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3587210 |
| Tested-by: Rajat Jain <rajatja@google.com> |
| Auto-Submit: Rajat Jain <rajatja@google.com> |
| Reviewed-by: YH Lin <yueherngl@chromium.org> |
| Reviewed-by: Dmitry Torokhov <dtor@chromium.org> |
| Commit-Queue: Rajat Jain <rajatja@google.com> |
| --- |
| drivers/acpi/property.c | 3 +++ |
| drivers/pci/pci-acpi.c | 16 ++++++++++++++++ |
| 2 files changed, 19 insertions(+) |
| |
| diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c |
| index b8d9eb9a433edd2c250dd68c6cdc2955ac03d577..294c61967f65e17f367be22d7843545e12bc846e 100644 |
| --- a/drivers/acpi/property.c |
| +++ b/drivers/acpi/property.c |
| @@ -48,6 +48,9 @@ static const guid_t prp_guids[] = { |
| /* Storage device needs D3 GUID: 5025030f-842f-4ab4-a561-99a5189762d0 */ |
| GUID_INIT(0x5025030f, 0x842f, 0x4ab4, |
| 0xa5, 0x61, 0x99, 0xa5, 0x18, 0x97, 0x62, 0xd0), |
| + /* DmaProperty for PCI devices GUID: 70d24161-6dd5-4c9e-8070-705531292865 */ |
| + GUID_INIT(0x70d24161, 0x6dd5, 0x4c9e, |
| + 0x80, 0x70, 0x70, 0x55, 0x31, 0x29, 0x28, 0x65), |
| }; |
| |
| /* ACPI _DSD data subnodes GUID: dbb8e3e6-5886-4ba6-8795-1319f52a966b */ |
| diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c |
| index a46fec776ad77b12220358ff2269b9214bd4c924..0399a037e0baeed37831762d200adc14d49f5bf5 100644 |
| --- a/drivers/pci/pci-acpi.c |
| +++ b/drivers/pci/pci-acpi.c |
| @@ -1370,12 +1370,28 @@ static void pci_acpi_set_external_facing(struct pci_dev *dev) |
| dev->external_facing = 1; |
| } |
| |
| +static void pci_acpi_check_for_dma_protection(struct pci_dev *dev) |
| +{ |
| + u8 val; |
| + |
| + /* |
| + * Property also used by Microsoft Windows for same purpose, |
| + * (to implement DMA protection from a device, using the IOMMU). |
| + */ |
| + if (device_property_read_u8(&dev->dev, "DmaProperty", &val)) |
| + return; |
| + |
| + if (val) |
| + dev->untrusted = 1; |
| +} |
| + |
| void pci_acpi_setup(struct device *dev, struct acpi_device *adev) |
| { |
| struct pci_dev *pci_dev = to_pci_dev(dev); |
| |
| pci_acpi_optimize_delay(pci_dev, adev->handle); |
| pci_acpi_set_external_facing(pci_dev); |
| + pci_acpi_check_for_dma_protection(pci_dev); |
| pci_acpi_add_edr_notifier(pci_dev); |
| |
| pci_acpi_add_pm_notifier(adev, pci_dev); |
| -- |
| 2.38.1.584.g0f3c55d4c2-goog |
| |