| From 5857546e14a16b43a61e1662f313350732cd003b Mon Sep 17 00:00:00 2001 |
| From: Jason Ekstrand <jason@jlekstrand.net> |
| Date: Tue, 13 Apr 2021 12:32:59 -0500 |
| Subject: [PATCH] FROMGIT: drm/i915/pm: Make the wm parameter of |
| print_wm_latency a pointer |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| This fixes the following build error with GCC 11: |
| |
| In function ‘snb_wm_latency_quirk’, |
| inlined from ‘ilk_setup_wm_latency’ at drivers/gpu/drm/i915/intel_pm.c:3109:3, |
| inlined from ‘intel_init_pm’ at drivers/gpu/drm/i915/intel_pm.c:7695:3: |
| drivers/gpu/drm/i915/intel_pm.c:3058:9: error: ‘intel_print_wm_latency’ reading 16 bytes from a region of size 10 [-Werror=stringop-overread] |
| 3058 | intel_print_wm_latency(dev_priv, "Primary", dev_priv->wm.pri_latency); |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| drivers/gpu/drm/i915/intel_pm.c: In function ‘intel_init_pm’: |
| drivers/gpu/drm/i915/intel_pm.c:3058:9: note: referencing argument 3 of type ‘const u16 *’ {aka ‘const short unsigned int *’} |
| drivers/gpu/drm/i915/intel_pm.c:2995:13: note: in a call to function ‘intel_print_wm_latency’ |
| 2995 | static void intel_print_wm_latency(struct drm_i915_private *dev_priv, |
| | ^~~~~~~~~~~~~~~~~~~~~~ |
| |
| As far as I can tell, we don't actually need 8 elements except on SKL |
| and that uses dev_priv->wm.skl_latency which has enough. |
| |
| Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> |
| Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20210413173259.472405-1-jason@jlekstrand.net |
| Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> |
| (cherry picked from commit c6deb5e97ded2623dfaec9b15a9bdd1b56464735 |
| git://anongit.freedesktop.org/drm-intel drm-intel-next) |
| Signed-off-by: Sean Paul <seanpaul@chromium.org> |
| |
| BUG=b:187093397 |
| TEST=Tested with single/multiple displays, suspend/resume, hotplugs on volteer/trogdor/dedede/zork, build tested on amd64/arm64-generic |
| |
| Change-Id: Ida535bfc38a3150a35eb0dbbab0d456f0d6d0a22 |
| Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2889237 |
| Reviewed-by: Sean Paul <seanpaul@chromium.org> |
| Reviewed-by: Alex Levin <levinale@google.com> |
| Tested-by: Sean Paul <seanpaul@chromium.org> |
| Commit-Queue: Sean Paul <seanpaul@chromium.org> |
| --- |
| drivers/gpu/drm/i915/intel_pm.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c |
| index 12ee23b5296d..105bce19d1df 100644 |
| --- a/drivers/gpu/drm/i915/intel_pm.c |
| +++ b/drivers/gpu/drm/i915/intel_pm.c |
| @@ -2994,7 +2994,7 @@ int ilk_wm_max_level(const struct drm_i915_private *dev_priv) |
| |
| static void intel_print_wm_latency(struct drm_i915_private *dev_priv, |
| const char *name, |
| - const u16 wm[]) |
| + const u16 *wm) |
| { |
| int level, max_level = ilk_wm_max_level(dev_priv); |
| |
| -- |
| 2.17.1 |
| |