| commit | be8490a664854cf8ce7b2960f0be19f6f8838f91 | [log] [tgz] |
|---|---|---|
| author | George Burgess IV <gbiv@google.com> | Fri Jun 11 18:35:21 2021 |
| committer | George Burgess <gbiv@chromium.org> | Fri Jun 18 19:23:47 2021 |
| tree | 4a6c3dbafbd30f1f1ed5a5441f342b4cb0db19f3 | |
| parent | 24accd96f5dbb5c793cfac8f41b275848c261950 [diff] |
compiler_wrapper: fix flaky tests We're running many tests in parallel that have dependencies on the `umask` global. We shouldn't be running these in parallel with each other, since they may read values for this that're set by other goroutines. Since these are difficult to spot, this CL does two things: - Requiring that all tests mark themselves as either readers of or writers to umask. Any test that does this gets run in serial with other tests that do it. - Requires code that modifies/reads the umask to go through `env.umask`, rather than `syscall.Umask`. This allows us to cheaply and accurately verify that a test's dependency on the process' umask was stated. BUG=b:186801841 TEST=`go test -count=100` passed Change-Id: Ifa871cfa48c005646499b21c1bfa1a4799ca641b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/2956692 Reviewed-by: Ryan Beltran <ryanbeltran@chromium.org> Tested-by: George Burgess <gbiv@chromium.org>
toolchain-utilsVarious utilities used by the Chrome OS toolchain team.
To run Python scripts in this directory, first run:
export PYTHONPATH=$(readlink -f .):$PYTHONPATH
from this directory.
Then you can run any script.
To get help on any script, type in python <script> --help, or refer to the header of the script for more information.