commit dc9ab2999b2b0ef4bf3aee5f6d10713f3cd372b5
author Edward Lemur <ehmaldonado@chromium.org> Fri May 17 20:30:20 2019
committer Commit Bot <commit-bot@chromium.org> Fri May 17 20:30:20 2019
tree 133de758f08df2b40d23b7864cf47337210b95fb
parent a66a74c4bcb62b3a9f339593ef9d9771b12e9b53

monorail: Fix TypeError in mr-launch-overview.

Bug: monorail:5419
Change-Id: I093572018e53aed0b43147f1e49d394bfc9937bc
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/1616854
Reviewed-by: Jason Robbins <jrobbins@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#23049}

appengine/monorail/static_src/elements/issue-detail/mr-launch-overview/mr-launch-overview.js

diff --git a/appengine/monorail/static_src/elements/issue-detail/mr-launch-overview/mr-launch-overview.js b/appengine/monorail/static_src/elements/issue-detail/mr-launch-overview/mr-launch-overview.js
index 048319e..82960f8 100644
--- a/appengine/monorail/static_src/elements/issue-detail/mr-launch-overview/mr-launch-overview.js
+++ b/appengine/monorail/static_src/elements/issue-detail/mr-launch-overview/mr-launch-overview.js
@@ -60,17 +60,23 @@
     };
   }
 
+  constructor() {
+    super();
+    this.approvals = [];
+    this.phases = [];
+    this.hidden = false;
+  }
+
   stateChanged(state) {
     if (!issue.issue(state)) return;
 
-    this.approvals = issue.issue(state).approvalValues;
-    this.phases = issue.issue(state).phases;
+    this.approvals = issue.issue(state).approvalValues || [];
+    this.phases = issue.issue(state).phases || [];
   }
 
   update(changedProperties) {
     if (changedProperties.has('phases') || changedProperties.has('approvals')) {
-      this.hidden = (!this.phases || !this.phases.length)
-        && (!this.approvals || !this.approvals.length);
+      this.hidden = !this.phases.length && !this.approvals.length;
     }
     super.update(changedProperties);
   }