| commit | 0fc1b6ae780e7ba854652bd5581f936abf824a5e | [log] [tgz] |
|---|---|---|
| author | Leonard Grey <lgrey@chromium.org> | Fri Oct 06 19:22:47 2023 |
| committer | Crashpad LUCI CQ <crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Oct 09 15:32:57 2023 |
| tree | 2ec26e2dac7ef07ec6b7c5dd29f19a8e94bb139b | |
| parent | a1b467ab45df0be7ed7b60443ceee7bf9081d818 [diff] |
Mac: update ProcessReaderMac and tests for macOS 14 dyld in macOS 14 has two changes that impact how we read in modules: - Timestamp is always empty - The executable appears *last* rather than first in the dyld_all_image_infos array (see comment for details) This change: - Removes all timestamp checks in the tests - Removes 10.6 era code that worked around a different "executable in the wrong place" issue. Replaces this with a new branch that checks if the executable is in the last position, and rotates it to the front if so. This is necessary instead of just swapping (as in the 10.6 code) so that it can match the order returned by the `dyld_get_image...` family. Bug: chromium:1452203 Change-Id: Iac9b29a0d9b9461b0ef386c9541661171ef9fd11 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4917145 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.