| commit | 2f6cffa676795d3ac66e50d5fde4a286edfc9377 | [log] [tgz] |
|---|---|---|
| author | Leonard Grey <lgrey@chromium.org> | Fri Oct 13 16:42:13 2023 |
| committer | Crashpad LUCI CQ <crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 13 17:23:26 2023 |
| tree | 7ad341d6627746f705294063b4aa0cd6d2274bb9 | |
| parent | f145b54e8378c8e2bd1fbb427684ca9b4c54ea9c [diff] |
Mac: don't consider module order in process reader tests This is a follow-up to 0fc1b6ae780e7ba854652bd5581f936abf824a5e. The change in macOS 14's dyld to insert new modules in the front of `dyld_all_image_infos` means that if any images are loaded after the executable and its direct dependencies, it's no longer possible to rotate the list to match the order used by the `dyld_get_image...` APIs. This forces us to dispense with checking the order at all except to ensure that the executable is first, and dyld itself is last. Additionally fixes an unreachable return introduced in 0fc1b6ae780e7ba854652bd5581f936abf824a5e. Bug: chromium:1452203 Change-Id: If0b09b9110d8f60d29cca79ea6a59050b0293c5e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4935952 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org>
Crashpad is a crash-reporting system.
Crashpad’s source code is hosted in a Git repository at https://chromium.googlesource.com/crashpad/crashpad.