Google Git
Sign in
chromium / devtools / devtools-frontend / 11bdafdbbd9bd153aea84b1fe03db4dff89d3aa9
commit11bdafdbbd9bd153aea84b1fe03db4dff89d3aa9[log] [tgz]
authorBenedikt Meurer <bmeurer@chromium.org>Mon Nov 14 10:37:02 2022
committerDevtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Nov 14 11:17:22 2022
treefcac26ff96aa048c04eeab512f73fc6bee03ab0d
parent61bdbc44d42fbb273b3bbabe9b509165e920e589 [diff]
[sources] Fix popover not working correctly for HTML and TSX.

The highlight range detection logic for JavaScript-like expressions
wasn't kicking in for HTML and TSX files, and therefore we only got
the fallback identifier-like token behavior, which works for quite
a lot of cases, but not reliably for everything.

Drive-by-refactoring: Reorganize the core highlight range detection
logic to be more unit test friendly and add some initial unit tests.

Bug: chromium:1383892, chromium:1361862, chromium:1383451
Change-Id: Ibad482ddfeded239e07d260bf7faeddfff629247
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4024906
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
2 files changed
tree: fcac26ff96aa048c04eeab512f73fc6bee03ab0d
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch