Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/3272bb922fe1f90284a0339c55185f2d09308ffd
commit
3272bb922fe1f90284a0339c55185f2d09308ffd
[log]
author
Jack Franklin <jacktfranklin@chromium.org>
Thu Apr 04 14:58:41 2024
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Apr 05 10:30:58 2024
tree
050b926e3b9843603eea3db1384a2c2c86869718
parent
198ddbaeb01579974ce5e392cba1a2415a230f2b [diff]
Don't use empty frames as mainFrame candidates

This CL fixes a rare case where we have a frame with no parent, no name
and no URL being used as the main frame, which is incorrect.

The fix is to only consider a frame a candidate as the main frame if it
has no parent (existing behaviour) and if it has a URL (new behaviour
introduced in this CL).

The RendererHandler will drop processes that have invalid URLs (which
includes empty strings), so it doesn't make sense to try to use a frame
with an invalid URL as the main frame ID.

Fixed:41494290
Change-Id: I1190e1cd7b657fa1f7dc3cf44706fe6662a9353d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5424631
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
5 files changed
tree: 050b926e3b9843603eea3db1384a2c2c86869718
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all TypeScript & CSS to run the DevTools webapp.

Source code and documentation

The frontend is available on chromium.googlesource.com. Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch