Google GitGoogle Git
Sign in
chromium/devtools/devtools-frontend/48b1ed3e80679d52f55ee1afae83da9be3ddbecb
commit
48b1ed3e80679d52f55ee1afae83da9be3ddbecb
[log]
author
Liviu Rau <liviurau@chromium.org>
Thu Sep 28 12:21:40 2023
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Sep 28 14:42:15 2023
tree
986370e96cda47c356305127d05bd708399ade65
parent
7deb66bfa347facf0c5e67a7fd72bae7e3b6206d [diff]
Avoid taking screenshots on ScreenshotErrors

This fixes a bug where after a screenshot error the `onError` handler would take a pair of target/frontend screenshots and obscure the original error.

Behaviour before the fix: https://luci-milo.appspot.com/ui/inv/u-liviurau-2023-09-28-11-48-00-7335b87ae21fb818/test-results

Behaviour after the fix: https://luci-milo.appspot.com/ui/inv/u-liviurau-2023-09-28-12-01-00-5cb60fc22ac97b0d/test-results

Bug: none
Change-Id: I6f86d89f1476adeb3a3ad9513f0d5c472410ea8f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4900637
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
1 file changed
tree: 986370e96cda47c356305127d05bd708399ade65
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. extensions/
  7. front_end/
  8. inspector_overlay/
  9. node_modules/
  10. scripts/
  11. test/
  12. third_party/
  13. v8/
  14. build
  15. buildtools
  16. .clang-format
  17. .editorconfig
  18. .eslintignore
  19. .eslintrc.js
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. .mailmap
  26. .npmignore
  27. .npmrc
  28. .style.yapf
  29. .stylelintignore
  30. .stylelintrc.json
  31. AUTHORS
  32. BUILD.gn
  33. codereview.settings
  34. DEPS
  35. LICENSE
  36. OWNERS
  37. package-lock.json
  38. package.json
  39. PRESUBMIT.py
  40. README.md
  41. tsconfig.json
  42. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch