Google Git
Sign in
chromium/devtools/devtools-frontend/4c25e2f022864cdc91e50eec6f9befaffe6072cc
commit
4c25e2f022864cdc91e50eec6f9befaffe6072cc
[log]
author
Ergün Erdoğmuş <ergunsh@chromium.org>
Wed Sep 28 10:53:17 2022
committer
Devtools-frontend LUCI CQ <devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com>
Fri Sep 30 05:45:00 2022
tree
f00133699f62d5a0f08aa03dd56cf2942eb81839
parent
4c80576083f7610755db6a0ab5474ecebe988a59 [diff]
Fix jumping to a wrong location after tab change

Before this, what was happening is the following:
* We were setting `scrollDOM` scroll properties
and it was scrolling directly
* After another update in CodeMirror, it was
calling `requestMeasure` which, while making
the measurement, also updating the scrollDOM
scroll position for some reason.

This CL fixes that situation by using
`scrollIntoView` effect which doesn't
cause `CodeMirror` to update the
`scrollDOM` scroll position.

See the screencasts here[1] and fixed behavior screencast in here[2]

[1]: https://bugs.chromium.org/p/chromium/issues/detail?id=1368113#c1
[2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1368113#c1

Fixed: 1368113
Change-Id: Ib5e6e0272907d7909043ed0226e4cc3c52e8e0cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3921602
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
7 files changed
tree: f00133699f62d5a0f08aa03dd56cf2942eb81839
  1. .vscode/
  2. build_overrides/
  3. config/
  4. docs/
  5. extension-api/
  6. front_end/
  7. inspector_overlay/
  8. node_modules/
  9. scripts/
  10. test/
  11. third_party/
  12. v8/
  13. .clang-format
  14. .editorconfig
  15. .eslintignore
  16. .eslintrc.js
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .mailmap
  21. .npmignore
  22. .npmrc
  23. .style.yapf
  24. .stylelintignore
  25. .stylelintrc.json
  26. AUTHORS
  27. BUILD.gn
  28. codereview.settings
  29. DEPS
  30. LICENSE
  31. OWNERS
  32. package-lock.json
  33. package.json
  34. PRESUBMIT.py
  35. README.md
  36. tsconfig.json
  37. WATCHLISTS
README.md

Chrome DevTools frontend

npm package

The client-side of the Chrome DevTools, including all JS & CSS to run the DevTools webapp.

Source code

The frontend is available on chromium.googlesource.com.

Project documentation

Check out the project documentation for instructions to set up, use, and maintain a DevTools front-end checkout, as well as design guidelines, and architectural documentation.

Additional references

Source mirrors

DevTools frontend repository is mirrored on GitHub.

DevTools frontend is also available on NPM as the chrome-devtools-frontend package. It's not currently available via CJS or ES modules, so consuming this package in other tools may require some effort.

The version number of the npm package (e.g. 1.0.373466) refers to the Chromium commit position of latest frontend git commit. It's incremented with every Chromium commit, however the package is updated roughly daily.

Getting in touch